Fix model_name requirements #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
can you set both? what happens if you do? iiuc it looks like checkpoint overrides - is this correct? if so, should we make them mutually exclusive, or at least communicate this overriding to the user? |
connermanuel
approved these changes
Mar 21, 2025
Contributor
connermanuel
left a comment
connermanuel
left a comment
There was a problem hiding this comment.
i was thinking of something like a mutually exclusive argparse group to enforce that exactly one arg is set, but i guess no such construct exists in click. id prefer to have both checks in the same place but nbd. thanks!
azahed98
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ENG-23543
Describe your changes
This PR removes the "require" flag from the
modelfield in the fine-tuning create command if thefrom_checkpointfield is set. The latter is enough to derive the model limits and settings required for fine-tuning.